Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

visp: update postinstall to support API #208554

Merged
merged 1 commit into from
Apr 2, 2025
Merged

visp: update postinstall to support API #208554

merged 1 commit into from
Apr 2, 2025
+8 −2

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Feb 22, 2025

Looks like #208060 only worked via tap since JSON API has bottle == nil.

Not sure if there is a better way, but trying to parse OS information from tab (e.g. os_version is macOS 14.7).

Also provide output similar to keg relocation. odebug would be better but looks like we never added support for that in postinstall.

Output would look like:

==> Changing SDK path in /opt/homebrew/Cellar/visp/3.6.0_12/lib/cmake/visp/VISPConfig.cmake
  from /Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk
    to /Library/Developer/CommandLineTools/SDKs/MacOSX15.sdk
==> Changing SDK path in /opt/homebrew/Cellar/visp/3.6.0_12/lib/cmake/visp/VISPModules.cmake
  from /Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk
    to /Library/Developer/CommandLineTools/SDKs/MacOSX15.sdk
==> Changing SDK path in /opt/homebrew/Cellar/visp/3.6.0_12/lib/pkgconfig/visp.pc
  from /Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk
    to /Library/Developer/CommandLineTools/SDKs/MacOSX15.sdk

One issue is output is always shown, even with brew postinstall visp --quiet. May want to consider adding odebug support first to avoid this.

Note that odebug in current brew postinstall is pretty much a code comment since --debug is dropped when executing postinstall.rb.

@cho-m cho-m added the CI-no-bottles Merge without publishing bottles label Feb 22, 2025
@github-actions github-actions bot added the boost Boost use is a significant feature of the PR or issue label Feb 22, 2025
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Mar 16, 2025
@fxcoudert fxcoudert removed the stale No recent activity label Mar 17, 2025
@fxcoudert
Copy link
Member

@cho-m apart from a weird audit, this seems ready to go

cho-m
cho-m commented Apr 1, 2025
View reviewed changes
@cho-m cho-m force-pushed the visp-postinstall-2 branch from cca8000 to b7249ee Compare April 1, 2025 17:41
@cho-m cho-m marked this pull request as ready for review April 1, 2025 17:41
@cho-m cho-m added the ready to merge PR can be merged once CI is green label Apr 1, 2025
@cho-m
Copy link
Member Author

cho-m commented Apr 1, 2025

Works for me locally when I:

  1. brew install visp
  2. Modify $(brew --prefix visp)/.brew/visp.rb
  3. brew postinstall visp
  4. brew test visp

@BrewTestBot BrewTestBot added this pull request to the merge queue Apr 2, 2025
Merged via the queue into master with commit 58f77a6 Apr 2, 2025
25 checks passed
@BrewTestBot BrewTestBot deleted the visp-postinstall-2 branch April 2, 2025 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlocab carlocab carlocab approved these changes

@daeho-ro daeho-ro daeho-ro approved these changes

Assignees
No one assigned
Labels
boost Boost use is a significant feature of the PR or issue CI-no-bottles Merge without publishing bottles ready to merge PR can be merged once CI is green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cho-m @fxcoudert @carlocab @daeho-ro @BrewTestBot